Ref: add new static analyser rule: category/java/bestpractices.xml/MissingOverride

rulesets/java-sheepit.xml

@@ -14,6 +14,7 @@
 	<rule ref="category/java/bestpractices.xml/AbstractClassWithoutAbstractMethod" />
 	<rule ref="category/java/bestpractices.xml/AvoidUsingHardCodedIP" />
 	<rule ref="category/java/bestpractices.xml/CheckResultSet" />
+	<rule ref="category/java/bestpractices.xml/MissingOverride" />
 	<rule ref="category/java/bestpractices.xml/OneDeclarationPerLine" />
 	<rule ref="category/java/bestpractices.xml/PrimitiveWrapperInstantiation" />
 	<rule ref="category/java/bestpractices.xml/UnusedFormalParameter" />

src/main/java/com/sheepit/client/Configuration.java

@@ -121,7 +121,7 @@ import lombok.Data;
 	/**
 	 * @return string formatted with SheepIt Admin Log Viewer in mind
 	 */
-	public String toString() {
+	@Override public String toString() {
 		String c = "    CFG: ";
 		String n ="\n";
 		return

src/main/java/com/sheepit/client/Job.java

@@ -133,6 +133,7 @@ import java.util.regex.Pattern;
 		return render;
 	}
 	
+	@Override
 	public String toString() {
 		return String
 				.format("Job (numFrame '%s' archiveChunks %s rendererMD5 '%s' ID '%s' pictureFilename '%s' jobPath '%s' gpu %s name '%s' updateRenderingStatusMethod '%s' render %s)",
@@ -570,7 +571,7 @@ import java.util.regex.Pattern;
 		final String filename_without_extension = getPrefixOutputImage() + getFrameNumber();
 		
 		FilenameFilter textFilter = new FilenameFilter() {
-			public boolean accept(File dir, String name) {
+			@Override public boolean accept(File dir, String name) {
 				return name.startsWith(filename_without_extension);
 			}
 		};

src/main/java/com/sheepit/client/Server.java

@@ -116,6 +116,7 @@ public class Server extends Thread {
 		this.httpClient = getOkHttpClient();
 	}
 	
+	@Override
 	public void run() {
 		this.stayAlive();
 	}
@@ -191,7 +192,7 @@ public class Server extends Thread {
 		}
 	}
 	
-	public String toString() {
+	@Override public String toString() {
 		return String.format("Server (base_url '%s', user_config %s", this.base_url, this.user_config);
 	}
 	

src/main/java/com/sheepit/client/hardware/hwid/impl/BaseHWInfoImpl.java

@@ -34,8 +34,8 @@ public class BaseHWInfoImpl implements BasicHWInfoStrategy {
     @Override public Optional<String> getProcessorName() {
         return Optional.of(hardware.getProcessor().getProcessorIdentifier().getName());
     }
-
-    public Optional<String> getHarddriveID() {
+	
+	@Override public Optional<String> getHarddriveID() {
         String rootMountpoint;
         if (Platform.isWindows()) {
             rootMountpoint = "C:";

src/main/java/com/sheepit/client/network/ProxyAuthenticator.java

@@ -32,7 +32,7 @@ public class ProxyAuthenticator extends Authenticator {
 		this.password = password;
 	}
 	
-	protected PasswordAuthentication getPasswordAuthentication() {
+	@Override protected PasswordAuthentication getPasswordAuthentication() {
 		return new PasswordAuthentication(user, password.toCharArray());
 	}
 }

src/main/java/com/sheepit/client/os/windows/WinProcess.java

@@ -188,7 +188,7 @@ public class WinProcess {
 		return result;
 	}
 	
-	public String toString() {
+	@Override public String toString() {
 		return "WinProcess(pid: " + this.pid + ", handle " + this.handle + ")";
 	}
 }

src/main/java/com/sheepit/client/standalone/GuiSwing.java

@@ -163,7 +163,7 @@ public class GuiSwing extends JFrame implements Gui {
 				sysTray = SystemTray.getSystemTray();
 				if (SystemTray.isSupported()) {
 					addWindowStateListener(new WindowStateListener() {
-						public void windowStateChanged(WindowEvent e) {
+						@Override public void windowStateChanged(WindowEvent e) {
 							if (e.getNewState() == ICONIFIED) {
 								hideToTray();
 							}

src/main/java/com/sheepit/client/standalone/swing/activity/Settings.java

@@ -556,8 +556,8 @@ public class Settings implements Activity {
 			new SaveAction().actionPerformed(null);
 		}
 	}
-
-	public void resizeWindow() {}
+	
+	@Override public void resizeWindow() {}
 	
 	public boolean checkDisplaySaveButton() {
 		boolean selected = useCPU.isSelected();

src/main/java/com/sheepit/client/standalone/swing/activity/Working.java

@@ -297,7 +297,7 @@ public class Working implements Activity {
 		parent.setSize(GuiSwing.WIDTH, 820);
 	}
 	
-	public void resizeWindow() {
+	@Override public void resizeWindow() {
 		parent.revalidate();
 		parent.repaint();
 	}

src/main/java/com/sheepit/client/standalone/text/CLIInputObserver.java

@@ -41,7 +41,7 @@ public class CLIInputObserver implements Runnable {
 		listeners.add(toAdd);
 	}
 	
-	public void run() {
+	@Override public void run() {
 		in = new BufferedReader(new InputStreamReader(System.in));
 		String line = "";