From 705203708bf2c477c5cb467cea54163a9d18c6c3 Mon Sep 17 00:00:00 2001
From: Laurent Clouet <4409640-laurent.clouet@users.noreply.gitlab.com>
Date: Fri, 7 Jun 2024 14:30:24 +0000
Subject: [PATCH] Ref: add new static analyser rule:
category/java/bestpractices.xml/MissingOverride
---
rulesets/java-sheepit.xml | 1 +
src/main/java/com/sheepit/client/Configuration.java | 2 +-
src/main/java/com/sheepit/client/Job.java | 3 ++-
src/main/java/com/sheepit/client/Server.java | 3 ++-
.../com/sheepit/client/hardware/hwid/impl/BaseHWInfoImpl.java | 4 ++--
.../java/com/sheepit/client/network/ProxyAuthenticator.java | 2 +-
src/main/java/com/sheepit/client/os/windows/WinProcess.java | 2 +-
src/main/java/com/sheepit/client/standalone/GuiSwing.java | 2 +-
.../sheepit/client/standalone/swing/activity/Settings.java | 4 ++--
.../com/sheepit/client/standalone/swing/activity/Working.java | 2 +-
.../com/sheepit/client/standalone/text/CLIInputObserver.java | 2 +-
11 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/rulesets/java-sheepit.xml b/rulesets/java-sheepit.xml
index f8a7470..18e8800 100644
--- a/rulesets/java-sheepit.xml
+++ b/rulesets/java-sheepit.xml
@@ -14,6 +14,7 @@
+
diff --git a/src/main/java/com/sheepit/client/Configuration.java b/src/main/java/com/sheepit/client/Configuration.java
index e0072b1..764fb59 100644
--- a/src/main/java/com/sheepit/client/Configuration.java
+++ b/src/main/java/com/sheepit/client/Configuration.java
@@ -121,7 +121,7 @@ import lombok.Data;
/**
* @return string formatted with SheepIt Admin Log Viewer in mind
*/
- public String toString() {
+ @Override public String toString() {
String c = " CFG: ";
String n ="\n";
return
diff --git a/src/main/java/com/sheepit/client/Job.java b/src/main/java/com/sheepit/client/Job.java
index da3bfa3..4900819 100644
--- a/src/main/java/com/sheepit/client/Job.java
+++ b/src/main/java/com/sheepit/client/Job.java
@@ -133,6 +133,7 @@ import java.util.regex.Pattern;
return render;
}
+ @Override
public String toString() {
return String
.format("Job (numFrame '%s' archiveChunks %s rendererMD5 '%s' ID '%s' pictureFilename '%s' jobPath '%s' gpu %s name '%s' updateRenderingStatusMethod '%s' render %s)",
@@ -570,7 +571,7 @@ import java.util.regex.Pattern;
final String filename_without_extension = getPrefixOutputImage() + getFrameNumber();
FilenameFilter textFilter = new FilenameFilter() {
- public boolean accept(File dir, String name) {
+ @Override public boolean accept(File dir, String name) {
return name.startsWith(filename_without_extension);
}
};
diff --git a/src/main/java/com/sheepit/client/Server.java b/src/main/java/com/sheepit/client/Server.java
index f5599af..6d7cde5 100644
--- a/src/main/java/com/sheepit/client/Server.java
+++ b/src/main/java/com/sheepit/client/Server.java
@@ -116,6 +116,7 @@ public class Server extends Thread {
this.httpClient = getOkHttpClient();
}
+ @Override
public void run() {
this.stayAlive();
}
@@ -191,7 +192,7 @@ public class Server extends Thread {
}
}
- public String toString() {
+ @Override public String toString() {
return String.format("Server (base_url '%s', user_config %s", this.base_url, this.user_config);
}
diff --git a/src/main/java/com/sheepit/client/hardware/hwid/impl/BaseHWInfoImpl.java b/src/main/java/com/sheepit/client/hardware/hwid/impl/BaseHWInfoImpl.java
index 7a8b304..ab6718c 100644
--- a/src/main/java/com/sheepit/client/hardware/hwid/impl/BaseHWInfoImpl.java
+++ b/src/main/java/com/sheepit/client/hardware/hwid/impl/BaseHWInfoImpl.java
@@ -34,8 +34,8 @@ public class BaseHWInfoImpl implements BasicHWInfoStrategy {
@Override public Optional getProcessorName() {
return Optional.of(hardware.getProcessor().getProcessorIdentifier().getName());
}
-
- public Optional getHarddriveID() {
+
+ @Override public Optional getHarddriveID() {
String rootMountpoint;
if (Platform.isWindows()) {
rootMountpoint = "C:";
diff --git a/src/main/java/com/sheepit/client/network/ProxyAuthenticator.java b/src/main/java/com/sheepit/client/network/ProxyAuthenticator.java
index ca2aca1..bf3c8fb 100644
--- a/src/main/java/com/sheepit/client/network/ProxyAuthenticator.java
+++ b/src/main/java/com/sheepit/client/network/ProxyAuthenticator.java
@@ -32,7 +32,7 @@ public class ProxyAuthenticator extends Authenticator {
this.password = password;
}
- protected PasswordAuthentication getPasswordAuthentication() {
+ @Override protected PasswordAuthentication getPasswordAuthentication() {
return new PasswordAuthentication(user, password.toCharArray());
}
}
diff --git a/src/main/java/com/sheepit/client/os/windows/WinProcess.java b/src/main/java/com/sheepit/client/os/windows/WinProcess.java
index d7758e7..153ae59 100644
--- a/src/main/java/com/sheepit/client/os/windows/WinProcess.java
+++ b/src/main/java/com/sheepit/client/os/windows/WinProcess.java
@@ -188,7 +188,7 @@ public class WinProcess {
return result;
}
- public String toString() {
+ @Override public String toString() {
return "WinProcess(pid: " + this.pid + ", handle " + this.handle + ")";
}
}
diff --git a/src/main/java/com/sheepit/client/standalone/GuiSwing.java b/src/main/java/com/sheepit/client/standalone/GuiSwing.java
index be131ba..97071bb 100644
--- a/src/main/java/com/sheepit/client/standalone/GuiSwing.java
+++ b/src/main/java/com/sheepit/client/standalone/GuiSwing.java
@@ -163,7 +163,7 @@ public class GuiSwing extends JFrame implements Gui {
sysTray = SystemTray.getSystemTray();
if (SystemTray.isSupported()) {
addWindowStateListener(new WindowStateListener() {
- public void windowStateChanged(WindowEvent e) {
+ @Override public void windowStateChanged(WindowEvent e) {
if (e.getNewState() == ICONIFIED) {
hideToTray();
}
diff --git a/src/main/java/com/sheepit/client/standalone/swing/activity/Settings.java b/src/main/java/com/sheepit/client/standalone/swing/activity/Settings.java
index 0010833..58c63fa 100644
--- a/src/main/java/com/sheepit/client/standalone/swing/activity/Settings.java
+++ b/src/main/java/com/sheepit/client/standalone/swing/activity/Settings.java
@@ -556,8 +556,8 @@ public class Settings implements Activity {
new SaveAction().actionPerformed(null);
}
}
-
- public void resizeWindow() {}
+
+ @Override public void resizeWindow() {}
public boolean checkDisplaySaveButton() {
boolean selected = useCPU.isSelected();
diff --git a/src/main/java/com/sheepit/client/standalone/swing/activity/Working.java b/src/main/java/com/sheepit/client/standalone/swing/activity/Working.java
index 0d405ca..598c78f 100644
--- a/src/main/java/com/sheepit/client/standalone/swing/activity/Working.java
+++ b/src/main/java/com/sheepit/client/standalone/swing/activity/Working.java
@@ -297,7 +297,7 @@ public class Working implements Activity {
parent.setSize(GuiSwing.WIDTH, 820);
}
- public void resizeWindow() {
+ @Override public void resizeWindow() {
parent.revalidate();
parent.repaint();
}
diff --git a/src/main/java/com/sheepit/client/standalone/text/CLIInputObserver.java b/src/main/java/com/sheepit/client/standalone/text/CLIInputObserver.java
index 0c38d20..e1bc0e8 100644
--- a/src/main/java/com/sheepit/client/standalone/text/CLIInputObserver.java
+++ b/src/main/java/com/sheepit/client/standalone/text/CLIInputObserver.java
@@ -41,7 +41,7 @@ public class CLIInputObserver implements Runnable {
listeners.add(toAdd);
}
- public void run() {
+ @Override public void run() {
in = new BufferedReader(new InputStreamReader(System.in));
String line = "";