Hypnagogia/ProjectStructure
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

zipseq ignore Thumbs.db

Browse Source
This commit is contained in:
Nathan
2025-12-29 11:19:34 -07:00
parent 45dc5956a2
commit e48c790d89
2 changed files with 267 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

253
.specstory/history/2025-12-29_17-30Z-zipseq-thumbs-db-exclusion.md Normal file
View File

@@ -0,0 +1,253 @@
<!-- Generated by SpecStory, Markdown v2.1.0 -->
<!-- cursor Session 709b2b05-b26b-4f58-8cd9-1a63b137e96e (2025-12-29 17:30Z) -->
# Zipseq Thumbs.db exclusion (2025-12-29 17:30Z)
_**User (2025-12-29 17:37Z)**_
zipseq needs to completely ignore Thumbs.db. It should be removed from any existing manifests. If the manifest is changed, but only Thumbs.db is changed (removed) it should not be rezipped.
---
_**Agent (model default, mode Agent)**_
---
Examining `zip_sequences.py` to understand how it handles manifests and files.
---
<tool-use data-tool-type="read" data-tool-name="read_file">
<details><summary>Tool use: **read_file** • Read file: zip_sequences.py</summary>
</details>
</tool-use>
---
---
Updating `zip_sequences.py` to ignore `Thumbs.db` files. Modifying file iteration, state loading, and state comparison.
---
<tool-use data-tool-type="read" data-tool-name="read_file">
<details><summary>Tool use: **read_file** • Read file: zip_sequences.py</summary>
</details>
</tool-use>
---
<tool-use data-tool-type="read" data-tool-name="read_file">
<details><summary>Tool use: **read_file** • Read file: zip_sequences.py</summary>
</details>
</tool-use>
---
<tool-use data-tool-type="read" data-tool-name="read_file">
<details><summary>Tool use: **read_file** • Read file: zip_sequences.py</summary>
</details>
</tool-use>
---
<tool-use data-tool-type="read" data-tool-name="read_file">
<details><summary>Tool use: **read_file** • Read file: zip_sequences.py</summary>
</details>
</tool-use>
---
---
Updating the code to ignore `Thumbs.db` files:
---
<tool-use data-tool-type="write" data-tool-name="search_replace">
<details><summary>Tool use: **search_replace** • Edit file: zip_sequences.py</summary>
**Chunk 1**
Lines added: 3, lines removed: undefined
```diff
@@ -522,4 +522,7 @@
continue
for filename in filenames:
+ # Ignore Thumbs.db files completely
+ if filename.lower() == "thumbs.db":
+ continue
yield path / filename
```
</details>
</tool-use>
---
<tool-use data-tool-type="write" data-tool-name="search_replace">
<details><summary>Tool use: **search_replace** • Edit file: zip_sequences.py</summary>
**Chunk 1**
Lines added: 6, lines removed: undefined
```diff
@@ -567,4 +567,10 @@
try:
state = json.loads(state_path.read_text())
+ # Remove Thumbs.db entries from loaded state
+ if "files" in state:
+ state["files"] = [
+ entry for entry in state.get("files", [])
+ if Path(entry.get("path", "")).name.lower() != "thumbs.db"
+ ]
# Normalize timestamps in loaded state to ensure consistency
# This handles state files created before normalization was added
```
</details>
</tool-use>
---
<tool-use data-tool-type="write" data-tool-name="search_replace">
<details><summary>Tool use: **search_replace** • Edit file: zip_sequences.py</summary>
**Chunk 1**
Lines added: 4, lines removed: 1
```diff
@@ -597,7 +597,10 @@
def normalize_state(state: dict) -&gt; dict:
- """Normalize timestamps in state to filesystem precision."""
+ """Normalize timestamps in state to filesystem precision and filter out Thumbs.db."""
normalized = {"files": []}
for entry in state.get("files", []):
+ # Ignore Thumbs.db files in state comparison
+ if Path(entry.get("path", "")).name.lower() == "thumbs.db":
+ continue
mtime_ns = entry["mtime_ns"]
if is_windows:
```
**Chunk 2**
Lines added: 1, lines removed: 1
```diff
@@ -610,5 +613,5 @@
return normalized
- # Compare normalized states
+ # Compare normalized states (Thumbs.db already filtered out)
normalized_seq = normalize_state(seq_state)
normalized_stored = normalize_state(stored_state)
```
</details>
</tool-use>
---
---
Checking for lint errors and verifying that `zip_sequence` uses the filtered file list:
---
<tool-use data-tool-type="generic" data-tool-name="read_lints">
<details>
<summary>Tool use: **read_lints** • Read lints for 1 file</summary>
Lint paths:
- `zip_sequences.py`
Lint results
**No lint errors found**
</details>
</tool-use>
---
<tool-use data-tool-type="read" data-tool-name="read_file">
<details><summary>Tool use: **read_file** • Read file: zip_sequences.py</summary>
</details>
</tool-use>
---
---
Verifying that `zip_sequence` uses the filtered iterator:
---
<tool-use data-tool-type="read" data-tool-name="read_file">
<details><summary>Tool use: **read_file** • Read file: zip_sequences.py</summary>
</details>
</tool-use>
---
---
## Summary of Changes
1. **`iter_sequence_files()`** — Skips `Thumbs.db` files during iteration, so they're never included in new states or archives.
2. **`load_state()`** — Removes any `Thumbs.db` entries from existing manifests when loading state files.
3. **`state_changed()`** — Filters out `Thumbs.db` entries from both states before comparison, so if the only change is removing `Thumbs.db`, it won't trigger a rezip.
Results:
- `Thumbs.db` files are ignored during scanning
- Existing manifests have `Thumbs.db` entries removed when loaded
- If a manifest change is only due to `Thumbs.db` removal, it won't trigger recompression
The `zip_sequence()` function automatically benefits from these changes since it uses `iter_sequence_files()`, which now filters out `Thumbs.db`.
No linting errors were found. The changes are ready to use.
---

16
zip_sequences.py
View File

@@ -521,6 +521,9 @@ def iter_sequence_files(seq_dir: Path) -> Iterator[Path]:
if is_archive_path(path):
continue
for filename in filenames:
# Ignore Thumbs.db files completely
if filename.lower() == "thumbs.db":
continue
yield path / filename
@@ -563,6 +566,12 @@ def load_state(state_path: Path) -> dict | None:
return None
try:
state = json.loads(state_path.read_text())
# Remove Thumbs.db entries from loaded state
if "files" in state:
state["files"] = [
entry for entry in state.get("files", [])
if Path(entry.get("path", "")).name.lower() != "thumbs.db"
]
# Normalize timestamps in loaded state to ensure consistency
# This handles state files created before normalization was added
is_windows = platform.system() == "Windows"
@@ -587,9 +596,12 @@ def state_changed(seq_state: dict, stored_state: dict | None, *, verbose: bool =
is_windows = platform.system() == "Windows"
def normalize_state(state: dict) -> dict:
"""Normalize timestamps in state to filesystem precision."""
"""Normalize timestamps in state to filesystem precision and filter out Thumbs.db."""
normalized = {"files": []}
for entry in state.get("files", []):
# Ignore Thumbs.db files in state comparison
if Path(entry.get("path", "")).name.lower() == "thumbs.db":
continue
mtime_ns = entry["mtime_ns"]
if is_windows:
mtime_ns = (mtime_ns // 100) * 100
@@ -600,7 +612,7 @@ def state_changed(seq_state: dict, stored_state: dict | None, *, verbose: bool =
})
return normalized
# Compare normalized states
# Compare normalized states (Thumbs.db already filtered out)
normalized_seq = normalize_state(seq_state)
normalized_stored = normalize_state(stored_state)