From a0e4f6b348944172d7bfa7eb6269392364206282 Mon Sep 17 00:00:00 2001
From: Laurent Clouet <laurent@nopnop.net>
Date: Thu, 6 Jun 2024 02:54:51 +0200
Subject: [PATCH] Ref: add more PMD rule:
 bestpractices.xml/UseCollectionIsEmpty

---
 rulesets/java-sheepit.xml                                     | 1 +
 .../sheepit/client/standalone/swing/activity/Settings.java    | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/rulesets/java-sheepit.xml b/rulesets/java-sheepit.xml
index 5c4deb0..6c28a97 100644
--- a/rulesets/java-sheepit.xml
+++ b/rulesets/java-sheepit.xml
@@ -18,6 +18,7 @@
 	<rule ref="category/java/bestpractices.xml/UnusedLocalVariable" />
 	<rule ref="category/java/bestpractices.xml/UnusedPrivateField" />
 	<rule ref="category/java/bestpractices.xml/UnusedPrivateMethod" />
+	<rule ref="category/java/bestpractices.xml/UseCollectionIsEmpty" />
 
 	<rule ref="category/java/codestyle.xml/ExtendsObject" />
 	<rule ref="category/java/codestyle.xml/ForLoopShouldBeWhileLoop" />
diff --git a/src/main/java/com/sheepit/client/standalone/swing/activity/Settings.java b/src/main/java/com/sheepit/client/standalone/swing/activity/Settings.java
index 2d8147d..0010833 100644
--- a/src/main/java/com/sheepit/client/standalone/swing/activity/Settings.java
+++ b/src/main/java/com/sheepit/client/standalone/swing/activity/Settings.java
@@ -271,7 +271,7 @@ public class Settings implements Activity {
 		gridbag.setConstraints(useCPU, compute_devices_constraints);
 		compute_devices_panel.add(useCPU);
 		
-		if (gpus.size() > 0 || GPU.hasHIPDevices()) {
+		if (gpus.isEmpty() == false || GPU.hasHIPDevices()) {
 			for (GPUDevice gpu : gpus) {
 				JCheckBoxGPU gpuCheckBox = new JCheckBoxGPU(gpu);
 				gpuCheckBox.setToolTipText(gpu.getId());
@@ -819,7 +819,7 @@ public class Settings implements Activity {
 					changes.add("Disable large Downloads");
 				}
 				
-				if (changes.size() > 0) {
+				if (changes.isEmpty() == false) {
 					warning = String.format(warning, String.join(", ", changes));
 					JOptionPane.showMessageDialog(null, warning);
 				}