From c1020d1534522535329fdfda06eddca742fe4711 Mon Sep 17 00:00:00 2001 From: Andy Li Date: Thu, 9 Apr 2020 23:39:09 +0800 Subject: [PATCH] Resolve compiler warnings (#200) * Fix: resolve compiler warnings * Fix: supress warnings about internal api usage See https://stackoverflow.com/a/19553686/6238618 --- build.gradle | 7 +++++++ src/com/sheepit/client/os/windows/WinProcess.java | 4 ++-- src/com/sheepit/client/standalone/Worker.java | 4 ++-- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/build.gradle b/build.gradle index cc1cf66..8b5a59f 100644 --- a/build.gradle +++ b/build.gradle @@ -12,6 +12,13 @@ apply plugin: 'com.github.johnrengelman.shadow' sourceCompatibility = '1.7' targetCompatibility = '1.7' +compileJava { + // Suppress warnings about internal api usage - https://stackoverflow.com/a/19553686/6238618 + options.fork = true + options.forkOptions.executable = 'javac' + options.compilerArgs << '-XDignore.symbol.file' +} + repositories { jcenter() mavenCentral() diff --git a/src/com/sheepit/client/os/windows/WinProcess.java b/src/com/sheepit/client/os/windows/WinProcess.java index 78ed2a8..0e7549c 100644 --- a/src/com/sheepit/client/os/windows/WinProcess.java +++ b/src/com/sheepit/client/os/windows/WinProcess.java @@ -64,7 +64,7 @@ public class WinProcess { private static boolean processHasGetPid() { try { - if (Process.class.getMethod("pid", null) != null) { + if (Process.class.getMethod("pid") != null) { return true; } } @@ -75,7 +75,7 @@ public class WinProcess { private static long getPid(Process process) { try { - return (long) Process.class.getMethod("pid", null).invoke(process, null); + return (long) Process.class.getMethod("pid").invoke(process); } catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException | NoSuchMethodException | SecurityException e) { } diff --git a/src/com/sheepit/client/standalone/Worker.java b/src/com/sheepit/client/standalone/Worker.java index 1c512d4..6f6420d 100644 --- a/src/com/sheepit/client/standalone/Worker.java +++ b/src/com/sheepit/client/standalone/Worker.java @@ -21,8 +21,8 @@ package com.sheepit.client.standalone; import org.kohsuke.args4j.CmdLineException; import org.kohsuke.args4j.CmdLineParser; -import static org.kohsuke.args4j.ExampleMode.REQUIRED; import org.kohsuke.args4j.Option; +import org.kohsuke.args4j.OptionHandlerFilter; import java.io.File; import java.net.MalformedURLException; @@ -126,7 +126,7 @@ public class Worker { System.err.println("Usage: "); parser.printUsage(System.err); System.err.println(); - System.err.println("Example: java " + this.getClass().getName() + " " + parser.printExample(REQUIRED)); + System.err.println("Example: java " + this.getClass().getName() + " " + parser.printExample(OptionHandlerFilter.REQUIRED)); return; }