From 3d55507c6a60f46db1f92b4018377ee01797f8b7 Mon Sep 17 00:00:00 2001
From: Laurent Clouet <laurent@nopnop.net>
Date: Thu, 6 Jun 2024 04:12:26 +0200
Subject: [PATCH] Ref: add more PMD rules

---
 rulesets/java-sheepit.xml | 88 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 87 insertions(+), 1 deletion(-)

diff --git a/rulesets/java-sheepit.xml b/rulesets/java-sheepit.xml
index 631f488..f8a7470 100644
--- a/rulesets/java-sheepit.xml
+++ b/rulesets/java-sheepit.xml
@@ -49,12 +49,98 @@
 	<rule ref="category/java/errorprone.xml/UnnecessaryConversionTemporary" />
 	<rule ref="category/java/errorprone.xml/UnusedNullCheckInEquals" />
 	<rule ref="category/java/errorprone.xml/UselessOperationOnImmutable" />
+	<rule ref="category/java/performance.xml/BigIntegerInstantiation" />
+	<rule ref="category/java/performance.xml/UselessStringValueOf" />
+	<rule ref="category/java/security.xml/HardCodedCryptoKey" />
+	<rule ref="category/java/security.xml/InsecureCryptoIv" />
+	<rule ref="category/java/performance.xml/UseStringBufferLength" />
+	<rule ref="category/java/bestpractices.xml/AccessorClassGeneration" />
+	<rule ref="category/java/bestpractices.xml/AccessorMethodGeneration" />
+	<rule ref="category/java/bestpractices.xml/AvoidMessageDigestField" />
+	<rule ref="category/java/bestpractices.xml/AvoidReassigningCatchVariables" />
+	<rule ref="category/java/bestpractices.xml/AvoidStringBufferField" />
+	<rule ref="category/java/bestpractices.xml/ConstantsInInterface" />
+	<rule ref="category/java/bestpractices.xml/DoubleBraceInitialization" />
+	<rule ref="category/java/bestpractices.xml/ForLoopCanBeForeach" />
+	<rule ref="category/java/bestpractices.xml/ForLoopVariableCount" />
+	<rule ref="category/java/performance.xml/AvoidArrayLoops" />
+	<rule ref="category/java/performance.xml/ConsecutiveAppendsShouldReuse" />
+	<rule ref="category/java/performance.xml/InefficientEmptyStringCheck" />
+	<rule ref="category/java/performance.xml/InefficientStringBuffering" />
+	<rule ref="category/java/performance.xml/OptimizableToArrayCall" />
+	<rule ref="category/java/performance.xml/StringInstantiation" />
+	<rule ref="category/java/performance.xml/StringToString" />
+	<rule ref="category/java/performance.xml/TooFewBranchesForASwitchStatement" />
+	<rule ref="category/java/performance.xml/UseArrayListInsteadOfVector" />
+	<rule ref="category/java/performance.xml/UseArraysAsList" />
+	<rule ref="category/java/performance.xml/UseIOStreamsWithApacheCommonsFileItem" />
+	<rule ref="category/java/bestpractices.xml/JUnitTestsShouldIncludeAssert" />
+	<rule ref="category/java/bestpractices.xml/JUnitUseExpected" />
+	<rule ref="category/java/bestpractices.xml/MethodReturnsInternalArray" />
+	<rule ref="category/java/bestpractices.xml/ReplaceEnumerationWithIterator" />
+	<rule ref="category/java/bestpractices.xml/ReplaceVectorWithList" />
+	<rule ref="category/java/bestpractices.xml/SimplifiableTestAssertion" />
+	<rule ref="category/java/bestpractices.xml/UseStandardCharsets" />
+	<rule ref="category/java/bestpractices.xml/WhileLoopWithLiteralBoolean" />
+	<rule ref="category/java/errorprone.xml/AssignmentToNonFinalStatic" />
+	<rule ref="category/java/errorprone.xml/AvoidAssertAsIdentifier" />
+	<rule ref="category/java/errorprone.xml/AvoidCallingFinalize" />
+	<rule ref="category/java/errorprone.xml/AvoidCatchingThrowable" />
+	<rule ref="category/java/errorprone.xml/AvoidEnumAsIdentifier" />
+	<rule ref="category/java/errorprone.xml/AvoidFieldNameMatchingTypeName" />
+	<rule ref="category/java/errorprone.xml/AvoidLosingExceptionInformation" />
+	<rule ref="category/java/errorprone.xml/CallSuperFirst" />
+	<rule ref="category/java/errorprone.xml/CallSuperLast" />
+	<rule ref="category/java/errorprone.xml/CloneMethodMustBePublic" />
+	<rule ref="category/java/errorprone.xml/CloneMethodMustImplementCloneable" />
+	<rule ref="category/java/errorprone.xml/CloneMethodReturnTypeMustMatchClassName" />
+	<rule ref="category/java/errorprone.xml/ComparisonWithNaN" />
+	<rule ref="category/java/errorprone.xml/DetachedTestCase" />
+	<rule ref="category/java/errorprone.xml/DoNotExtendJavaLangThrowable" />
+	<rule ref="category/java/errorprone.xml/DoNotHardCodeSDCard" />
+	<rule ref="category/java/errorprone.xml/DoNotThrowExceptionInFinally" />
+	<rule ref="category/java/errorprone.xml/DontImportSun" />
+	<rule ref="category/java/errorprone.xml/EmptyFinalizer" />
+	<rule ref="category/java/errorprone.xml/EqualsNull" />
+	<rule ref="category/java/errorprone.xml/FinalizeOverloaded" />
+	<rule ref="category/java/errorprone.xml/FinalizeShouldBeProtected" />
+	<rule ref="category/java/errorprone.xml/IdempotentOperations" />
+	<rule ref="category/java/errorprone.xml/InstantiationToGetClass" />
+	<rule ref="category/java/errorprone.xml/InvalidLogMessageFormat" />
+	<rule ref="category/java/errorprone.xml/JUnitSpelling" />
+	<rule ref="category/java/errorprone.xml/JUnitStaticSuite" />
+	<rule ref="category/java/errorprone.xml/MethodWithSameNameAsEnclosingClass" />
+	<rule ref="category/java/errorprone.xml/MissingStaticMethodInNonInstantiatableClass" />
+	<rule ref="category/java/errorprone.xml/MoreThanOneLogger" />
+	<rule ref="category/java/errorprone.xml/NonCaseLabelInSwitchStatement" />
+	<rule ref="category/java/errorprone.xml/NonStaticInitializer" />
+	<rule ref="category/java/errorprone.xml/ProperCloneImplementation" />
+	<rule ref="category/java/errorprone.xml/SingleMethodSingleton" />
+	<rule ref="category/java/errorprone.xml/SingletonClassReturningNewInstance" />
+	<rule ref="category/java/errorprone.xml/StaticEJBFieldShouldBeFinal" />
+	<rule ref="category/java/errorprone.xml/StringBufferInstantiationWithChar" />
+	<rule ref="category/java/errorprone.xml/SuspiciousEqualsMethodName" />
+	<rule ref="category/java/errorprone.xml/SuspiciousHashcodeMethodName" />
+	<rule ref="category/java/errorprone.xml/SuspiciousOctalEscape" />
+	<rule ref="category/java/errorprone.xml/TestClassWithoutTestCases" />
 	<rule ref="category/java/errorprone.xml/UnnecessaryBooleanAssertion" />
 	<rule ref="category/java/errorprone.xml/UnnecessaryCaseChange" />
+	<rule ref="category/java/errorprone.xml/UseProperClassLoader" />
 	<rule ref="category/java/multithreading.xml/AvoidThreadGroup" />
+	<rule ref="category/java/multithreading.xml/AvoidUsingVolatile" />
 	<rule ref="category/java/multithreading.xml/DontCallThreadRun" />
 	<rule ref="category/java/multithreading.xml/DoubleCheckedLocking" />
-	<rule ref="category/java/performance.xml/BigIntegerInstantiation" />
+	<rule ref="category/java/multithreading.xml/UnsynchronizedStaticFormatter" />
+	<rule ref="category/java/design.xml/AbstractClassWithoutAnyMethod" />
+	<rule ref="category/java/design.xml/AvoidThrowingNewInstanceOfSameException" />
+	<rule ref="category/java/design.xml/AvoidThrowingNullPointerException" />
+	<rule ref="category/java/design.xml/CouplingBetweenObjects" />
+	<rule ref="category/java/design.xml/DoNotExtendJavaLangError" />
+	<rule ref="category/java/design.xml/ExcessivePublicCount" />
+	<rule ref="category/java/design.xml/InvalidJavaBean" />
+	<rule ref="category/java/design.xml/LogicInversion" />
+	<rule ref="category/java/design.xml/SimplifyBooleanReturns" />
+	<rule ref="category/java/design.xml/SimplifyConditional" />
 
 
 </ruleset>