Raincloud/sheepit-shadow-nabber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'pmd/new-rule-7' into 'master'

Browse Source 
Ref: add new static analyser rule: category/java/bestpractices.xml/LooseCoupling

See merge request sheepitrenderfarm/client!320
This commit is contained in:
Laurent Clouet
2024-06-07 14:19:00 +00:00
parent bcb9eff255 89ff34f0bb
commit 9e8364ea93
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
rulesets/java-sheepit.xml
View File

@@ -21,7 +21,7 @@
<rule ref="category/java/bestpractices.xml/UnusedPrivateField" /> <rule ref="category/java/bestpractices.xml/UnusedPrivateField" />
<rule ref="category/java/bestpractices.xml/UnusedPrivateMethod" /> <rule ref="category/java/bestpractices.xml/UnusedPrivateMethod" />
<rule ref="category/java/bestpractices.xml/UseCollectionIsEmpty" /> <rule ref="category/java/bestpractices.xml/UseCollectionIsEmpty" />
<rule ref="category/java/bestpractices.xml/LooseCoupling" />
<rule ref="category/java/codestyle.xml/ExtendsObject" /> <rule ref="category/java/codestyle.xml/ExtendsObject" />
<rule ref="category/java/codestyle.xml/ForLoopShouldBeWhileLoop" /> <rule ref="category/java/codestyle.xml/ForLoopShouldBeWhileLoop" />
<rule ref="category/java/codestyle.xml/TooManyStaticImports" /> <rule ref="category/java/codestyle.xml/TooManyStaticImports" />

2
src/main/java/com/sheepit/client/Configuration.java
View File

@@ -366,7 +366,7 @@ import lombok.Data;
* Only logs instances where something was detected, otherwise is it will only print "FilesystemHealthCheck started" * Only logs instances where something was detected, otherwise is it will only print "FilesystemHealthCheck started"
* @return an ArrayList of Strings containing all logs of the FSHealth check * @return an ArrayList of Strings containing all logs of the FSHealth check
*/ */
public ArrayList<String> filesystemHealthCheck() { public List<String> filesystemHealthCheck() {
ArrayList<String> logs = new ArrayList<>(); ArrayList<String> logs = new ArrayList<>();
String f = "FSHealth: "; String f = "FSHealth: ";
logs.add(f + "FilesystemHealthCheck started"); logs.add(f + "FilesystemHealthCheck started");