force PMD v7

PMD v7: fix new design/SimplifyBooleanReturns matches
PMD v7: fix new bestpractices/UnusedAssignment matches
PMD v7: fix new bestpractices/LiteralsFirstInComparisons matches
PMD v7: fix new codestyle/UnnecessaryFullyQualifiedName matches
PMD v7: fix new bestpractices/LooseCoupling matches
PMD rules: bestpractices/UseVarargs
PMD rules: sort lines
This commit is contained in:
M*C*O
2024-06-10 16:34:12 +00:00
committed by Laurent Clouet
parent 46f893327d
commit 48f3761656
17 changed files with 121 additions and 122 deletions

View File

@@ -470,7 +470,7 @@ import java.util.regex.Pattern;
// Once the process is finished (either finished successfully or with an error) move back to
// base icon (isolated S with no progress bar)
gui.updateTrayIcon(Job.SHOW_BASE_ICON);
gui.updateTrayIcon(SHOW_BASE_ICON);
return Error.Type.RENDERER_OUT_OF_MEMORY;
}
@@ -494,7 +494,7 @@ import java.util.regex.Pattern;
}
// Put back base icon
gui.updateTrayIcon(Job.SHOW_BASE_ICON);
gui.updateTrayIcon(SHOW_BASE_ICON);
process.kill();
maybeCleanWorkingDir(error);
for (String logline : configuration.filesystemHealthCheck()) {
@@ -545,7 +545,7 @@ import java.util.regex.Pattern;
}
// Put back base icon
gui.updateTrayIcon(Job.SHOW_BASE_ICON);
gui.updateTrayIcon(SHOW_BASE_ICON);
log.debug("end of rendering");
@@ -714,7 +714,7 @@ import java.util.regex.Pattern;
}
private void updateRenderingStatus(String line, int progress) {
if (getUpdateRenderingStatusMethod() == null || getUpdateRenderingStatusMethod().equals(Job.UPDATE_METHOD_BY_REMAINING_TIME)) {
if (getUpdateRenderingStatusMethod() == null || UPDATE_METHOD_BY_REMAINING_TIME.equals(getUpdateRenderingStatusMethod())) {
String search_remaining = "remaining:";
int index = line.toLowerCase().indexOf(search_remaining);
if (index != -1) {
@@ -760,7 +760,7 @@ import java.util.regex.Pattern;
}
}
}
else if (Job.UPDATE_METHOD_BY_TILE.equals(getUpdateRenderingStatusMethod())) {
else if (UPDATE_METHOD_BY_TILE.equals(getUpdateRenderingStatusMethod())) {
String search = " Tile ";
int index = line.lastIndexOf(search);
if (index != -1) {