Fix: remove certificate bypass (#240)

This commit is contained in:
Luis Uguina
2020-06-03 00:04:54 +10:00
committed by GitHub
parent 4cf51013e6
commit 399cb9971f

View File

@@ -605,26 +605,7 @@ public class Server extends Thread {
private OkHttpClient getOkHttpClient() { private OkHttpClient getOkHttpClient() {
try { try {
final TrustManager[] trustAllCerts = new TrustManager[] { new X509TrustManager() {
@Override public void checkClientTrusted(java.security.cert.X509Certificate[] chain, String authType) throws CertificateException {
}
@Override public void checkServerTrusted(java.security.cert.X509Certificate[] chain, String authType) throws CertificateException {
}
@Override public java.security.cert.X509Certificate[] getAcceptedIssuers() {
return new java.security.cert.X509Certificate[] {};
}
} };
final SSLContext sslContext = SSLContext.getInstance("SSL");
sslContext.init(null, trustAllCerts, new java.security.SecureRandom());
final SSLSocketFactory sslSocketFactory = sslContext.getSocketFactory();
OkHttpClient.Builder builder = new OkHttpClient.Builder(); OkHttpClient.Builder builder = new OkHttpClient.Builder();
builder.sslSocketFactory(sslSocketFactory, (X509TrustManager) trustAllCerts[0]);
CookieManager cookieManager = new CookieManager(); CookieManager cookieManager = new CookieManager();
cookieManager.setCookiePolicy(CookiePolicy.ACCEPT_ALL); cookieManager.setCookiePolicy(CookiePolicy.ACCEPT_ALL);
@@ -645,12 +626,6 @@ public class Server extends Thread {
builder.readTimeout(1, TimeUnit.MINUTES); // No proxy - 60 seconds max builder.readTimeout(1, TimeUnit.MINUTES); // No proxy - 60 seconds max
} }
builder.hostnameVerifier(new HostnameVerifier() {
@Override public boolean verify(String hostname, SSLSession session) {
return true; // Accept all certificates
}
});
return builder.build(); return builder.build();
} }
catch (Exception e) { catch (Exception e) {