Raincloud/sheepit-shadow-nabber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup: switch instead of ifs

Browse Source
This commit is contained in:
Mathis Chenuet
2015-01-28 20:11:57 +00:00
committed by Laurent Clouet
parent bda6691159
commit 3497ff7333
2 changed files with 60 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

76
src/com/sheepit/client/Client.java
View File

@@ -537,46 +537,48 @@ public class Client {
new_env.put("BLENDER_USER_CONFIG", this.config.workingDirectory.getAbsolutePath().replace("\\", "\\\\")); new_env.put("BLENDER_USER_CONFIG", this.config.workingDirectory.getAbsolutePath().replace("\\", "\\\\"));
for (String arg : command1) { for (String arg : command1) {
if (arg.equals(".c")) { switch (arg) {
command.add(ajob.getScenePath()); case ".c":
command.add("-P"); command.add(ajob.getScenePath());
command.add("-P");
try { try {
script_file = File.createTempFile("script_", "", this.config.workingDirectory); script_file = File.createTempFile("script_", "", this.config.workingDirectory);
File file = new File(script_file.getAbsolutePath()); File file = new File(script_file.getAbsolutePath());
FileWriter txt; FileWriter txt;
txt = new FileWriter(file); txt = new FileWriter(file);
PrintWriter out = new PrintWriter(txt); PrintWriter out = new PrintWriter(txt);
out.write(ajob.getScript()); out.write(ajob.getScript());
out.write("\n"); out.write("\n");
out.write(core_script); // GPU part out.write(core_script); // GPU part
out.write("\n"); // GPU part out.write("\n"); // GPU part
out.close(); out.close();
command.add(script_file.getAbsolutePath()); command.add(script_file.getAbsolutePath());
} }
catch (IOException e) { catch (IOException e) {
return Error.Type.UNKNOWN; return Error.Type.UNKNOWN;
} }
script_file.deleteOnExit(); script_file.deleteOnExit();
} break;
else if (arg.equals(".e")) { case ".e":
command.add(ajob.getRendererPath()); command.add(ajob.getRendererPath());
// the number of cores has to be put after the binary and before the scene arg // the number of cores has to be put after the binary and before the scene arg
if (this.config.getNbCores() > 0) { if (this.config.getNbCores() > 0) {
command.add("-t"); command.add("-t");
command.add(Integer.toString(this.config.getNbCores())); command.add(Integer.toString(this.config.getNbCores()));
} }
} break;
else if (arg.equals(".o")) { case ".o":
command.add(this.config.workingDirectory.getAbsolutePath() + File.separator + ajob.getPrefixOutputImage()); command.add(this.config.workingDirectory.getAbsolutePath() + File.separator + ajob.getPrefixOutputImage());
} break;
else if (arg.equals(".f")) { case ".f":
command.add(ajob.getFrameNumber()); command.add(ajob.getFrameNumber());
} break;
else { default:
command.add(arg); command.add(arg);
break;
} }
} }

36
src/com/sheepit/client/standalone/Worker.java
View File

@@ -266,23 +266,25 @@ public class Worker {
Log.getInstance(config).debug("client version " + config.getJarVersion()); Log.getInstance(config).debug("client version " + config.getJarVersion());
Gui gui; Gui gui;
if (ui_type.equals("oneline")) { switch (ui_type) {
if (config.getPrintLog()) { case "oneline":
System.out.println("OneLine UI can not be used if verbose mode is enabled"); if (config.getPrintLog()) {
System.exit(2); System.out.println("OneLine UI can not be used if verbose mode is enabled");
} System.exit(2);
gui = new GuiTextOneLine(); }
} gui = new GuiTextOneLine();
else if (ui_type.equals("swing")) { break;
if (java.awt.GraphicsEnvironment.isHeadless()) { case "swing":
System.out.println("Graphical ui can not be launch."); if (java.awt.GraphicsEnvironment.isHeadless()) {
System.out.println("You should set a DISPLAY or use a text ui (via -ui oneline or -ui text)."); System.out.println("Graphical ui can not be launch.");
System.exit(3); System.out.println("You should set a DISPLAY or use a text ui (via -ui oneline or -ui text).");
} System.exit(3);
gui = new GuiSwing(); }
} gui = new GuiSwing();
else { break;
gui = new GuiText(); default:
gui = new GuiText();
break;
} }
Client cli = new Client(gui, config, server); Client cli = new Client(gui, config, server);
gui.setClient(cli); gui.setClient(cli);